lkml.org 
[lkml]   [2022]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -next] panic: Add register_panic_notifier and unregister_panic_notifier
From
On 01/08/2022 10:58, xuqiang (M) wrote:
> 在 2022/8/1 20:12, Guilherme G. Piccoli 写道:
>> On 01/08/2022 07:05, Xu Qiang wrote:
>>> Add two methods to manipulate panic_notifier_list and export them.
>>> Subsequently, panic_notifier_list is changed to static variable.
>>>
>>> Signed-off-by: Xu Qiang <xuqiang36@huawei.com>
>> Hi Xu Qiang, first of all, thanks for your patch!
>> I'd like to mention 2 things about it:
>>
>> (a) As-is, there's no much use for it - I mean, you're adding a helper
>> but you didn't change the uses of such notifier list addition (and there
>> are plenty of them). Are you intend to change it, or just use the new
>> API in new calls?
> After this patch comes in, I will replace all the old interfaces with
> the new ones.
>>
>> (b) Even more important: we are working in a panic notifier refactor
>> [0], and that'll add new lists. I'm still working on that, plan to
>> submit (relatively) soon. Maybe worth to wait it, if this one is not urgent?
> I can wait for your patch to be incorporated before submitting it.

Great, thanks Xu! I'll include you in the CC list of the V2 =)

\
 
 \ /
  Last update: 2022-08-01 16:26    [W:0.075 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site