lkml.org 
[lkml]   [2022]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 28/65] tcp: Fix a data-race around sysctl_tcp_autocorking.
    Date
    From: Kuniyuki Iwashima <kuniyu@amazon.com>

    [ Upstream commit 85225e6f0a76e6745bc841c9f25169c509b573d8 ]

    While reading sysctl_tcp_autocorking, it can be changed concurrently.
    Thus, we need to add READ_ONCE() to its reader.

    Fixes: f54b311142a9 ("tcp: auto corking")
    Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/ipv4/tcp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
    index f1fd26bb199c..78460eb39b3a 100644
    --- a/net/ipv4/tcp.c
    +++ b/net/ipv4/tcp.c
    @@ -698,7 +698,7 @@ static bool tcp_should_autocork(struct sock *sk, struct sk_buff *skb,
    int size_goal)
    {
    return skb->len < size_goal &&
    - sock_net(sk)->ipv4.sysctl_tcp_autocorking &&
    + READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_autocorking) &&
    !tcp_rtx_queue_empty(sk) &&
    refcount_read(&sk->sk_wmem_alloc) > skb->truesize;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-08-01 13:55    [W:4.173 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site