lkml.org 
[lkml]   [2022]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH 1/2] spi: dt-binding: add Microchip CoreQSPI compatible
Date
Hey Suresh,

On 01/08/2022 10:42, Naga Sureshkumar Relli wrote:
> Add compatible string for Microchip CoreQSPI controller.
>
> Signed-off-by: Naga Sureshkumar Relli <nagasuresh.relli@microchip.com>
> ---
> .../devicetree/bindings/spi/microchip,mpfs-spi.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> index 7326c0a28d16..b65f4e070796 100644
> --- a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> @@ -14,9 +14,13 @@ allOf:
>
> properties:
> compatible:
> - enum:
> - - microchip,mpfs-spi
> - - microchip,mpfs-qspi
> + oneOf:
> + - description: Microchip's Polarfire SoC SPI controller.
^
(This is a capital F btw)

> + const: microchip,mpfs-spi
> + - description: Microchip's Polarfire SoC QSPI controller.
> + const: microchip,mpfs-qspi
> + - description: Microchip's FPGA QSPI controller.
> + const: microchip,coreqspi-rtl-v2

I am not sure that this is the correct "hierarchy". coreQSPI has a
subset of the registers of the "hard" QSPI & the same driver works
for both at the moment. The "hard" QSPI is based on the FPGA core,
so I think this should be changed to something like the following:

properties:
compatible:
oneOf:
- description: Microchip's PolarFire SoC QSPI controller
items:
- const: microchip,mpfs-qspi
- const: microchip,coreqspi-rtl-v2
- description: Microchip's fabric based QSPI IP core
const: microchip,coreqspi-rtl-v2
- description: Microchip's PolarFire SoC SPI controller
const: microchip,mpfs-spi

Unrelated to this patch, but a

diff --git a/MAINTAINERS b/MAINTAINERS
index f4202a19faa1..887bfee5c7af 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17526,6 +17526,7 @@ F: drivers/pci/controller/pcie-microchip-host.c
F: drivers/rtc/rtc-mpfs.c
F: drivers/soc/microchip/
F: drivers/spi/spi-microchip-core.c
+F: drivers/spi/spi-microchip-core-qspi.c
F: drivers/usb/musb/mpfs.c
F: include/soc/microchip/mpfs.h

Would be nice too.

Thanks,
Conor.
\
 
 \ /
  Last update: 2022-08-01 12:18    [W:0.161 / U:0.808 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site