Messages in this thread | | | From | Huacai Chen <> | Date | Tue, 2 Aug 2022 09:53:42 +0800 | Subject | Re: [PATCH 2/4] LoongArch: Add prologue unwinder support |
| |
Hi, Ruoyao,
On Tue, Aug 2, 2022 at 9:39 AM Xi Ruoyao <xry111@xry111.site> wrote: > > On Tue, 2022-08-02 at 09:34 +0800, Huacai Chen wrote: > > > > #define UNWINDER_GUESS 0 > > > > #define UNWINDER_PROLOGURE 1 > > > > > > Maybe it's better to define with enum type? > > > enum unwind_type { > > > UNWINDER_GUESS, > > > UNWINDER_PROLOGURE, > > > }; > > Both macro and enum are acceptable, but enum is essentially "int", > > while the "type" member is "char" here. > > "0" or "1" will also be "int" (C99 6.4.4.1 para 5). OK, then Zhang Qing has her rights to choose. :)
Huacai > > -- > Xi Ruoyao <xry111@xry111.site> > School of Aerospace Science and Technology, Xidian University
| |