Messages in this thread | | | Date | Mon, 1 Aug 2022 09:55:58 +0200 | From | Pali Rohár <> | Subject | Re: [PATCH] powerpc/85xx: P2020: Add law_trgt_if property to PCIe DT nodes |
| |
On Monday 01 August 2022 13:38:32 Michael Ellerman wrote: > Rob Herring <robh+dt@kernel.org> writes: > > On Fri, Jul 29, 2022 at 7:17 AM Michael Ellerman > > <patch-notifications@ellerman.id.au> wrote: > >> > >> On Wed, 4 May 2022 20:08:22 +0200, Pali Rohár wrote: > >> > DT law_trgt_if property defines Local Access Window Target Interface. > >> > > >> > Local Access Window Target Interface is used for identifying individual > >> > peripheral and mapping its memory to CPU. Interface id is defined by > >> > hardware itself. > >> > > >> > U-Boot uses law_trgt_if DT property in PCIe nodes for configuring memory > >> > mapping of individual PCIe controllers. > >> > > >> > [...] > >> > >> Applied to powerpc/next. > >> > >> [1/1] powerpc/85xx: P2020: Add law_trgt_if property to PCIe DT nodes > >> https://git.kernel.org/powerpc/c/1f00b5ab992c122c51bc37662b3b4df5963462f3 > > > > Why? Minimally, it needs a vendor prefix and s/_/-/ as I commented. > > OK. I misread your "maybe that's fine" as approval. > > Pali can you send a fixup patch please? > > cheers
No I cannot. This is how this property is used by bootloaders for at least 10 years. There are underlines (not hyphens) and there is no vendor prefix.
| |