lkml.org 
[lkml]   [2022]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] staging: vt6655: Use loop in vt6655_mac_write_bssid_addr
From
Date
On Fri, 2022-07-08 at 14:29 +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 06, 2022 at 09:19:01PM +0200, Philipp Hortmann wrote:
> > Use loop in vt6655_mac_write_bssid_addr to avoid multiple
> > similar statements.
[]
> > diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
[]
> > @@ -192,12 +192,8 @@ device_set_options(struct vnt_private *priv)
> > static void vt6655_mac_write_bssid_addr(void __iomem *iobase, const u8 *mac_addr)
[]
> > + for (int i = 0; i < 6; i++)
>
> Taking advantage of the new compiler level I see, nice :)

Not sure this is altogether a great idea as it may
make backporting a bit difficult, but it's already
in the kernel in a few places.


\
 
 \ /
  Last update: 2022-07-09 06:08    [W:0.924 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site