lkml.org 
[lkml]   [2022]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 0/5] drm/modes: Command line mode selection fixes and improvements
From
Hi Geert,

On 7/8/22 20:21, Geert Uytterhoeven wrote:
> Hi all,
>
> This patch series contains fixes and improvements for specifying video
> modes on the kernel command line.
>
> This has been tested on ARAnyM using a work-in-progress Atari DRM driver
> (more info and related patches can be found in [1]).
>
> Thanks for your comments!
>
> [1] "[PATCH v3 00/10] drm: Add support for low-color frame buffer formats"
> https://lore.kernel.org/r/cover.1657294931.git.geert@linux-m68k.org
>
> Geert Uytterhoeven (5):
> drm/modes: parse_cmdline: Handle empty mode name part
> drm/modes: Extract drm_mode_parse_cmdline_named_mode()
> drm/modes: parse_cmdline: Make mode->*specified handling more uniform
> drm/modes: Add support for driver-specific named modes
> drm/modes: parse_cmdline: Add support for named modes containing
> dashes

Thanks, I have some remarks on patches 1/5 and 2/5 the rest looks
good to me.

For 1/5 and 2/5 with my remarks addressed:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

For 3/5, 4/5 and 5/5:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

>
> drivers/gpu/drm/drm_modes.c | 57 ++++++++++++++++++++++++++-----------
> include/drm/drm_connector.h | 10 +++++++
> 2 files changed, 50 insertions(+), 17 deletions(-)
>

\
 
 \ /
  Last update: 2022-07-08 21:39    [W:0.098 / U:1.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site