Messages in this thread | | | From | Nadav Amit <> | Subject | Re: [PATCH] x86/mm/tlb: ignore f->new_tlb_gen when zero | Date | Fri, 8 Jul 2022 17:09:59 +0000 |
| |
On Jul 8, 2022, at 10:01 AM, Dave Hansen <dave.hansen@intel.com> wrote:
> ⚠ External Email > > On 7/8/22 09:54, Nadav Amit wrote: >> Since the bug was not during MADV_DONTNEED there is no reason for the >> results to be any different. >> >> Famous last words? > > Considering that your patch broke the kernel a way that surprised us > all, I think caution is warranted. Re-running a microbenchmark that > takes five minutes and stresses things a bit is the least you can do, I > think.
I will send it later today. I was just pointing that the failing code-path is different than the one I measured.
| |