Messages in this thread | | | From | Akhil R <> | Subject | RE: [PATCH v2 1/3] dt-bindings: dmaengine: Add compatible for Tegra234 | Date | Fri, 8 Jul 2022 16:10:47 +0000 |
| |
> On Thu, Jul 07, 2022 at 08:27:27PM +0530, Akhil R wrote: > > Document the compatible string used by GPCDMA controller for Tegra234. > > > > Signed-off-by: Akhil R <akhilrajeev@nvidia.com> > > --- > > .../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git > > a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml > > b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml > > index 9dd1476d1849..81f3badbc8ec 100644 > > --- > > a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml > > +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.ya > > +++ ml > > @@ -23,6 +23,7 @@ properties: > > oneOf: > > - const: nvidia,tegra186-gpcdma > > - items: > > + - const: nvidia,tegra234-gpcdma > > - const: nvidia,tegra194-gpcdma > > - const: nvidia,tegra186-gpcdma > > I don't think this works because it will now fail to validate Tegra194 device trees. > You'll need to create a separate set of items for Tegra234.
If I update it as below, would it work?
- items: - const: nvidia,tegra234-gpcdma - const: nvidia,tegra186-gpcdma
- items: - const: nvidia,tegra194-gpcdma - const: nvidia,tegra186-gpcdma
Regards, Akhil
-- nvpublic
| |