lkml.org 
[lkml]   [2022]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] ASoC: mediatek: mt8186: Remove condition with no effect
From
Il 08/07/22 12:19, Jiaxin Yu ha scritto:
> On Fri, 2022-07-08 at 10:01 +0200, AngeloGioacchino Del Regno wrote:
>> Il 08/07/22 04:46, Zhongjun Tan ha scritto:
>>> From: Zhongjun Tan <tanzhongjun@coolpad.com>
>>>
>>> Remove condition with no effect
>>>
>>> Signed-off-by: Zhongjun Tan <tanzhongjun@coolpad.com>
>>> ---
>>> sound/soc/mediatek/mt8186/mt8186-dai-adda.c | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/sound/soc/mediatek/mt8186/mt8186-dai-adda.c
>>> b/sound/soc/mediatek/mt8186/mt8186-dai-adda.c
>>> index db71b032770d..6be6d4f3b585 100644
>>> --- a/sound/soc/mediatek/mt8186/mt8186-dai-adda.c
>>> +++ b/sound/soc/mediatek/mt8186/mt8186-dai-adda.c
>>> @@ -295,8 +295,6 @@ static int mtk_adda_pad_top_event(struct
>>> snd_soc_dapm_widget *w,
>>> case SND_SOC_DAPM_PRE_PMU:
>>> if (afe_priv->mtkaif_protocol ==
>>> MTKAIF_PROTOCOL_2_CLK_P2)
>>> regmap_write(afe->regmap, AFE_AUD_PAD_TOP,
>>> 0x39);
>>> - else if (afe_priv->mtkaif_protocol ==
>>> MTKAIF_PROTOCOL_2)
>>> - regmap_write(afe->regmap, AFE_AUD_PAD_TOP,
>>> 0x31);
>>
>> I think that this needs some clarification from MediaTek: was 0x31 a
>> typo here?
>>
>> Regards,
>> Angelo
>>
> Hi Angelo,
>
> This patch can be accepted. The 0x31 is not typo, the logic of this
> code is not concise enough.
>
> Thanks,
> Jiaxin.Yu

Thank you for the clarification. In this case:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Cheers!

>
>>> else
>>> regmap_write(afe->regmap, AFE_AUD_PAD_TOP,
>>> 0x31);
>>> break;
>>
>>
>

\
 
 \ /
  Last update: 2022-07-08 17:45    [W:0.057 / U:1.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site