Messages in this thread | | | From | Christophe Leroy <> | Subject | Re: [RFC PATCH v3 01/12] objtool: Fix SEGFAULT | Date | Fri, 8 Jul 2022 15:10:43 +0000 |
| |
Le 24/06/2022 à 20:32, Sathvika Vasireddy a écrit : > From: Christophe Leroy <christophe.leroy@csgroup.eu>
This patch needs some description. Could be:
find_insn() will return NULL in case of failure. Check insn in order to avoid a kernel Oops for NULL pointer dereference.
> > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> > --- > tools/objtool/check.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/objtool/check.c b/tools/objtool/check.c > index 190b2f6e360a..6cb07e151588 100644 > --- a/tools/objtool/check.c > +++ b/tools/objtool/check.c > @@ -203,7 +203,7 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func, > return false; > > insn = find_insn(file, func->sec, func->offset); > - if (!insn->func) > + if (!insn || !insn->func) > return false; > > func_for_each_insn(file, func, insn) {
| |