lkml.org 
[lkml]   [2022]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 11/11] ASoC: jz4740-i2s: Refactor DAI probe/remove ops as component ops
Hi Aidan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on broonie-sound/for-next]
[cannot apply to linus/master v5.19-rc5 next-20220707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Aidan-MacDonald/ASoC-cleanups-and-improvements-for-jz4740-i2s/20220708-034953
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: arm64-buildonly-randconfig-r006-20220707 (https://download.01.org/0day-ci/archive/20220708/202207081227.ibiEiprJ-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 562c3467a6738aa89203f72fc1d1343e5baadf3c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/d990302616fcc22f1e2a3b963c25fdec9d787251
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Aidan-MacDonald/ASoC-cleanups-and-improvements-for-jz4740-i2s/20220708-034953
git checkout d990302616fcc22f1e2a3b963c25fdec9d787251
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash sound/soc/jz4740/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> sound/soc/jz4740/jz4740-i2s.c:442:2: error: use of undeclared identifier 'ret'
ret = clk_prepare_enable(i2s->clk_aic);
^
sound/soc/jz4740/jz4740-i2s.c:443:6: error: use of undeclared identifier 'ret'
if (ret)
^
sound/soc/jz4740/jz4740-i2s.c:444:10: error: use of undeclared identifier 'ret'
return ret;
^
3 errors generated.


vim +/ret +442 sound/soc/jz4740/jz4740-i2s.c

437
438 static int jz4740_i2s_probe(struct snd_soc_component *component)
439 {
440 struct jz4740_i2s *i2s = snd_soc_component_get_drvdata(component);
441
> 442 ret = clk_prepare_enable(i2s->clk_aic);
443 if (ret)
444 return ret;
445
446 regmap_write(i2s->regmap, JZ_REG_AIC_CONF, JZ_AIC_CONF_RESET);
447
448 regmap_write(i2s->regmap, JZ_REG_AIC_CONF,
449 JZ_AIC_CONF_OVERFLOW_PLAY_LAST |
450 JZ_AIC_CONF_I2S | JZ_AIC_CONF_INTERNAL_CODEC);
451
452 regmap_field_write(i2s->field_rx_fifo_thresh, 7);
453 regmap_field_write(i2s->field_tx_fifo_thresh, 8);
454
455 return 0;
456 }
457

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-07-08 06:49    [W:0.094 / U:0.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site