Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 8 Jul 2022 13:29:21 +0200 | Subject | Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32() |
| |
On Fri, Jul 8, 2022 at 12:22 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Thu, Jul 7, 2022 at 11:03 AM Cezary Rojewski > <cezary.rojewski@intel.com> wrote: > > > > Add strsplit_u32() and its __user variant to allow for splitting > > specified string into array of u32 tokens. > > And I believe we have more of this done in old code. > Since all callers use ',' as a delimiter, have you considered using > get_options()? > > > Originally this functionality was added for the SOF sound driver. As > > more users are on the horizon, relocate it so it becomes a common good. > > Maybe it can be fixed just there.
Forgot to add that we (trying to) don't accept new code in the lib w.o. test cases. get_options() is somehow covered. If you have different test cases in mind, do not hesitate to add!
-- With Best Regards, Andy Shevchenko
| |