lkml.org 
[lkml]   [2022]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] Re: [net-next PATCH V3 06/12] octeontx2-af: Drop rules for NPC MCAM
Date
-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Friday, July 8, 2022 6:24 AM
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri Goutham <sgoutham@marvell.com>; davem@davemloft.net; edumazet@google.com; pabeni@redhat.com
Subject: [EXT] Re: [net-next PATCH V3 06/12] octeontx2-af: Drop rules for NPC MCAM

External Email

----------------------------------------------------------------------
On Thu, 7 Jul 2022 13:03:47 +0530 Ratheesh Kannoth wrote:
> NPC exact match table installs drop on hit rules in NPC mcam for each
> channel. This rule has broadcast and multicast bits cleared. Exact
> match bit cleared and channel bits set. If exact match table hit bit
> is 0, corresponding NPC mcam drop rule will be hit for the packet and
> will be dropped.

>kdoc:

>drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1462: warning: bad line: u8 cgx_id, lmac_id;

Done. Posted new patch set.

>clang:

.>/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1228:6: warning: variable 'disable_cam' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (entry->cmd)
^~~~~~~~~~
>../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1232:6: note: uninitialized use occurs here
if (disable_cam) {
^~~~~~~~~~~
>./drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1228:2: note: remove the 'if' if its condition is always true
> if (entry->cmd)
^~~~~~~~~~~~~~~
>../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1201:18: note: initialize the variable 'disable_cam' to silence this warning
bool disable_cam;
^
= 0
>../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1308:6: warning: variable 'enable_cam' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
> if (cmd)
^~~
>../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1312:6: note: uninitialized use occurs here
> if (enable_cam) {
^~~~~~~~~~
>../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1308:2: note: remove the 'if' if its condition is always true
> if (cmd)
> ^~~~~~~~
>../drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_hash.c:1275:17: note: initialize the variable 'enable_cam' to silence this warning
> bool enable_cam;
^
> = 0

Done. Posted new patch.

\
 
 \ /
  Last update: 2022-07-08 06:46    [W:0.069 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site