lkml.org 
[lkml]   [2022]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 1/2] clk: pistachio: Fix initconst confusion
    Date
    From: Andi Kleen <ak@linux.intel.com>

    A variable pointing to const isn't const itself. It has to contain
    "const" keyword after "*" too. So to keep it in __initconst (and not
    mark properly as __initdata), add the "const" keyword exactly there.

    Note we need to update struct pistachio_mux too. On the other hand, the
    clk core already counts with "const char *const" already.

    [js] more explanatory commit message.

    Cc: Michael Turquette <mturquette@baylibre.com>
    Cc: Stephen Boyd <sboyd@kernel.org>
    Cc: linux-clk@vger.kernel.org
    Cc: Martin Liska <mliska@suse.cz>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---

    Notes:
    [v2] as suggested by Stephen, instead of switching to __initdata, make
    it real const

    drivers/clk/pistachio/clk.h | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/clk/pistachio/clk.h b/drivers/clk/pistachio/clk.h
    index f9c31e3a0e47..2f4ffbd98282 100644
    --- a/drivers/clk/pistachio/clk.h
    +++ b/drivers/clk/pistachio/clk.h
    @@ -31,10 +31,10 @@ struct pistachio_mux {
    unsigned int shift;
    unsigned int num_parents;
    const char *name;
    - const char **parents;
    + const char *const *parents;
    };

    -#define PNAME(x) static const char *x[] __initconst
    +#define PNAME(x) static const char *const x[] __initconst

    #define MUX(_id, _name, _pnames, _reg, _shift) \
    { \
    --
    2.36.1
    \
     
     \ /
      Last update: 2022-07-08 09:14    [W:3.181 / U:0.796 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site