lkml.org 
[lkml]   [2022]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 02/10] drm/i915/gvt: Replace roundup with DIV_ROUND_UP
    Date
    It's a bit redundant for the maths here using roundup.

    Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
    Tested-by: Terrence Xu <terrence.xu@intel.com>
    Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
    ---
    drivers/gpu/drm/i915/gvt/kvmgt.c | 7 ++-----
    1 file changed, 2 insertions(+), 5 deletions(-)

    diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
    index 8c67c9aba82d..7ce7b09aa5b2 100644
    --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
    +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
    @@ -231,11 +231,9 @@ static void intel_gvt_cleanup_vgpu_type_groups(struct intel_gvt *gvt)
    static void gvt_unpin_guest_page(struct intel_vgpu *vgpu, unsigned long gfn,
    unsigned long size)
    {
    - int total_pages;
    + int total_pages = DIV_ROUND_UP(size, PAGE_SIZE);
    int npage;

    - total_pages = roundup(size, PAGE_SIZE) / PAGE_SIZE;
    -
    for (npage = 0; npage < total_pages; npage++) {
    unsigned long cur_gfn = gfn + npage;

    @@ -247,12 +245,11 @@ static void gvt_unpin_guest_page(struct intel_vgpu *vgpu, unsigned long gfn,
    static int gvt_pin_guest_page(struct intel_vgpu *vgpu, unsigned long gfn,
    unsigned long size, struct page **page)
    {
    + int total_pages = DIV_ROUND_UP(size, PAGE_SIZE);
    unsigned long base_pfn = 0;
    - int total_pages;
    int npage;
    int ret;

    - total_pages = roundup(size, PAGE_SIZE) / PAGE_SIZE;
    /*
    * We pin the pages one-by-one to avoid allocating a big arrary
    * on stack to hold pfns.
    --
    2.17.1
    \
     
     \ /
      Last update: 2022-07-09 00:46    [W:4.118 / U:1.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site