Messages in this thread | | | From | Rob Herring <> | Date | Fri, 8 Jul 2022 15:49:03 -0600 | Subject | Re: [PATCH] of/irq: parse interrupts-extended during irq init heirarchy calculation |
| |
On Fri, Jul 8, 2022 at 10:52 AM Ben Dooks <ben.dooks@sifive.com> wrote: > > When the irq controler code works out the heirarchy for initialialisation > it only looks at interrupt-parent properties, but controllers such as the > RISC-V PLIC use a extended-interrupt property and therefore do not get > properly considered during initialisation. > > This means that if anything changes in the driver initialisation order > then the PLIC can get called before the CLINT nodes, and thus interrupts > do not get configured properly and the init continues without noticing > the error until drivers fail due to having no interrupts delivered. > > Add code to the of_irq_init that checks for the extended-interrupt > property and adds these parent nodes so that they can be considered > during the calculations of whether an irq controller node can be > initialised.
Isn't this already fixed by commit e91033621d56 ("of/irq: Use interrupts-extended to find parent")?
Rob
| |