Messages in this thread | | | Date | Thu, 7 Jul 2022 11:31:48 +0530 | Subject | Re: [PATCH v5 1/3] dt-bindings: clock: Add resets for LPASS audio clock controller for SC7280 | From | Taniya Das <> |
| |
Hi Stephen,
On 6/16/2022 1:29 AM, Stephen Boyd wrote: > Quoting Taniya Das (2022-06-14 08:33:04) >> Add support for LPASS audio clock gating for RX/TX/SWA core bus clocks >> for SC7280. Update reg property min/max items in YAML schema. >> >> Fixes: 4185b27b3bef ("dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7280"). >> Acked-by: Rob Herring <robh@kernel.org> >> Signed-off-by: Taniya Das <quic_tdas@quicinc.com> >> --- >> .../clock/qcom,sc7280-lpasscorecc.yaml | 19 ++++++++++++++++--- >> .../clock/qcom,lpassaudiocc-sc7280.h | 5 +++++ >> 2 files changed, 21 insertions(+), 3 deletions(-) > > I'm still wondering if the binding is correct, given the overlapping reg > properties. Should we be removing a compatible or two and adding a DT > property like "qcom,adsp-bypass-mode" instead?
I can pick this up as cleanup and send it across for review. If you are fine now please help pick these up.
-- Thanks & Regards, Taniya Das.
| |