Messages in this thread | | | Date | Thu, 7 Jul 2022 16:29:12 +0300 | From | Serge Semin <> | Subject | Re: [PATCH v5 1/4] spi: dw: Fix IP-core versions macro |
| |
Hi Nandhini
On Wed, Jul 06, 2022 at 12:20:36PM +0800, nandhini.srikandan@intel.com wrote: > From: Nandhini Srikandan <nandhini.srikandan@intel.com> > > Fixes: 2cc8d9227bbb ("spi: dw: Introduce Synopsys IP-core versions interface") > Signed-off-by: Nandhini Srikandan <nandhini.srikandan@intel.com>
As Mark already noted each patch is supposed to have a changelog [1]. Please add a detailed explanation of the problem above the tags block [1].
[1] "Patch formatting and changelogs" Documentation/process/5.Posting.rst
-Sergey
> --- > drivers/spi/spi-dw.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h > index d5ee5130601e..79d853f6d192 100644 > --- a/drivers/spi/spi-dw.h > +++ b/drivers/spi/spi-dw.h > @@ -23,7 +23,7 @@ > ((_dws)->ip == DW_ ## _ip ## _ID) > > #define __dw_spi_ver_cmp(_dws, _ip, _ver, _op) \ > - (dw_spi_ip_is(_dws, _ip) && (_dws)->ver _op DW_ ## _ip ## _ver) > + (dw_spi_ip_is(_dws, _ip) && (_dws)->ver _op DW_ ## _ip ## _ ## _ver) > > #define dw_spi_ver_is(_dws, _ip, _ver) __dw_spi_ver_cmp(_dws, _ip, _ver, ==) > > -- > 2.17.1 >
| |