lkml.org 
[lkml]   [2022]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net-next v4 08/27] net: introduce __skb_fill_page_desc_noacc
    Date
    Managed pages contain pinned userspace pages and controlled by upper
    layers, there is no need in tracking skb->pfmemalloc for them. Introduce
    a helper for filling frags but ignoring page tracking, it'll be needed
    later.

    Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
    ---
    include/linux/skbuff.h | 28 +++++++++++++++++-----------
    1 file changed, 17 insertions(+), 11 deletions(-)

    diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
    index 07004593d7ca..1111adefd906 100644
    --- a/include/linux/skbuff.h
    +++ b/include/linux/skbuff.h
    @@ -2550,6 +2550,22 @@ static inline unsigned int skb_pagelen(const struct sk_buff *skb)
    return skb_headlen(skb) + __skb_pagelen(skb);
    }

    +static inline void __skb_fill_page_desc_noacc(struct skb_shared_info *shinfo,
    + int i, struct page *page,
    + int off, int size)
    +{
    + skb_frag_t *frag = &shinfo->frags[i];
    +
    + /*
    + * Propagate page pfmemalloc to the skb if we can. The problem is
    + * that not all callers have unique ownership of the page but rely
    + * on page_is_pfmemalloc doing the right thing(tm).
    + */
    + frag->bv_page = page;
    + frag->bv_offset = off;
    + skb_frag_size_set(frag, size);
    +}
    +
    /**
    * __skb_fill_page_desc - initialise a paged fragment in an skb
    * @skb: buffer containing fragment to be initialised
    @@ -2566,17 +2582,7 @@ static inline unsigned int skb_pagelen(const struct sk_buff *skb)
    static inline void __skb_fill_page_desc(struct sk_buff *skb, int i,
    struct page *page, int off, int size)
    {
    - skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
    -
    - /*
    - * Propagate page pfmemalloc to the skb if we can. The problem is
    - * that not all callers have unique ownership of the page but rely
    - * on page_is_pfmemalloc doing the right thing(tm).
    - */
    - frag->bv_page = page;
    - frag->bv_offset = off;
    - skb_frag_size_set(frag, size);
    -
    + __skb_fill_page_desc_noacc(skb_shinfo(skb), i, page, off, size);
    page = compound_head(page);
    if (page_is_pfmemalloc(page))
    skb->pfmemalloc = true;
    --
    2.36.1
    \
     
     \ /
      Last update: 2022-07-07 13:54    [W:4.121 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site