Messages in this thread Patch in this message | | | Date | Thu, 07 Jul 2022 08:15:53 -0000 | From | "irqchip-bot for Loic Pallardy" <> | Subject | [irqchip: irq/irqchip-next] irqchip/stm32-exti: Fix irq_mask/irq_unmask for direct events |
| |
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: f8b3eb4245113c8a9156d5db8e80c6134127bcc1 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/f8b3eb4245113c8a9156d5db8e80c6134127bcc1 Author: Loic Pallardy <loic.pallardy@foss.st.com> AuthorDate: Mon, 06 Jun 2022 18:27:53 +02:00 Committer: Marc Zyngier <maz@kernel.org> CommitterDate: Thu, 07 Jul 2022 09:07:44 +01:00
irqchip/stm32-exti: Fix irq_mask/irq_unmask for direct events
The driver has to mask/unmask the corresponding flag in the Interrupt Mask Register (IMR). This is already done for configurable event, while direct events only forward the mask/unmask request to the parent.
Use the existing stm32_exti_h_mask()/stm32_exti_h_unmask() for direct events too.
Signed-off-by: Loic Pallardy <loic.pallardy@foss.st.com> Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com> Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20220606162757.415354-3-antonio.borneo@foss.st.com --- drivers/irqchip/irq-stm32-exti.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c index 10c9c74..1145f06 100644 --- a/drivers/irqchip/irq-stm32-exti.c +++ b/drivers/irqchip/irq-stm32-exti.c @@ -691,8 +691,8 @@ static struct irq_chip stm32_exti_h_chip_direct = { .name = "stm32-exti-h-direct", .irq_eoi = irq_chip_eoi_parent, .irq_ack = irq_chip_ack_parent, - .irq_mask = irq_chip_mask_parent, - .irq_unmask = irq_chip_unmask_parent, + .irq_mask = stm32_exti_h_mask, + .irq_unmask = stm32_exti_h_unmask, .irq_retrigger = irq_chip_retrigger_hierarchy, .irq_set_type = irq_chip_set_type_parent, .irq_set_wake = stm32_exti_h_set_wake,
| |