Messages in this thread | | | Date | Thu, 7 Jul 2022 17:21:01 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH] neighbor: tracing: Have neigh_create event use __string() |
| |
On Tue, 5 Jul 2022 18:37:41 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (Google)" <rostedt@goodmis.org> > > The dev field of the neigh_create event uses __dynamic_array() with a > fixed size, which defeats the purpose of __dynamic_array(). Looking at the > logic, as it already uses __assign_str(), just use the same logic in > __string to create the size needed. It appears that because "dev" can be > NULL, it needs the check. But __string() can have the same checks as > __assign_str() so use them there too. > > Cc: David Ahern <dsahern@gmail.com> > Cc: David S. Miller <davem@davemloft.net> > Cc: netdev@vger.kernel.org > Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> > --- > > [ This is simpler logic than the fib* events, so I figured just > convert to __string() instead of a static __array() ]
This one is also going via your tree?
| |