Messages in this thread | | | Subject | Re: [PATCH] net: rxrpc: fix clang -Wformat warning | From | Joe Perches <> | Date | Thu, 07 Jul 2022 16:10:22 -0700 |
| |
On Wed, 2022-07-06 at 16:56 -0700, Justin Stitt wrote: > When building with Clang we encounter this warning: > > net/rxrpc/rxkad.c:434:33: error: format specifies type 'unsigned short' > > but the argument has type 'u32' (aka 'unsigned int') [-Werror,-Wformat] > > _leave(" = %d [set %hx]", ret, y);
Does anyone still use these debugging macros in rxrpc or is it historic cruft?
net/rxrpc/ar-internal.h-#define kenter(FMT,...) dbgprintk("==> %s("FMT")",__func__ ,##__VA_ARGS__) net/rxrpc/ar-internal.h-#define kleave(FMT,...) dbgprintk("<== %s()"FMT"",__func__ ,##__VA_ARGS__) net/rxrpc/ar-internal.h-#define kdebug(FMT,...) dbgprintk(" "FMT ,##__VA_ARGS__) net/rxrpc/ar-internal.h-#define kproto(FMT,...) dbgprintk("### "FMT ,##__VA_ARGS__) net/rxrpc/ar-internal.h-#define knet(FMT,...) dbgprintk("@@@ "FMT ,##__VA_ARGS__)
etc...
[]
net/rxrpc/Kconfig:config AF_RXRPC_DEBUG net/rxrpc/Kconfig- bool "RxRPC dynamic debugging" net/rxrpc/Kconfig- help net/rxrpc/Kconfig- Say Y here to make runtime controllable debugging messages appear. net/rxrpc/Kconfig- net/rxrpc/Kconfig- See Documentation/networking/rxrpc.rst
This seems to show there is debugging documentation, but it doesn't seem to exist in this file.
> diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c [] > @@ -431,7 +431,7 @@ static int rxkad_secure_packet(struct rxrpc_call *call, > break; > } > > - _leave(" = %d [set %hx]", ret, y); > + _leave(" = %d [set %u]", ret, y); > return ret; > } >
| |