Messages in this thread | | | From | Kuniyuki Iwashima <> | Subject | Re: [PATCH v2 net 10/12] cipso: Fix data-races around sysctl. | Date | Thu, 7 Jul 2022 15:15:37 -0700 |
| |
From: Paul Moore <paul@paul-moore.com> Date: Thu, 7 Jul 2022 15:15:52 -0400 > On Wed, Jul 6, 2022 at 7:43 PM Kuniyuki Iwashima <kuniyu@amazon.com> wrote: > > > > While reading cipso sysctl variables, they can be changed concurrently. > > So, we need to add READ_ONCE() to avoid data-races. > > > > Fixes: 446fda4f2682 ("[NetLabel]: CIPSOv4 engine") > > Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com> > > --- > > CC: Paul Moore <paul@paul-moore.com> > > Thanks for the patch, this looks good to me. However, in the future > you should probably drop the extra "---" separator (just leave the one > before the diffstat below) and move my "Cc:" up above "Fixes:". > > Acked-by: Paul Moore <paul@paul-moore.com>
I was wondering if both CC and Acked-by should stay in each commit, but will do so in the next time.
Thank you for taking a look!
| |