Messages in this thread | | | From | Barry Song <> | Date | Fri, 8 Jul 2022 09:12:14 +1200 | Subject | Re: [PATCH 3/4] mm: rmap: Extend tlbbatch APIs to fit new platforms |
| |
On Fri, Jul 8, 2022 at 4:43 AM Dave Hansen <dave.hansen@intel.com> wrote: > > On 7/7/22 05:52, Barry Song wrote: > > static inline void arch_tlbbatch_add_mm(struct arch_tlbflush_unmap_batch *batch, > > - struct mm_struct *mm) > > + struct mm_struct *mm, > > + struct vm_area_struct *vma, > > + unsigned long uaddr) > > { > > It's not a huge deal, but could we pass 'vma' _instead_ of 'mm'? The > implementations could then just use vma->vm_mm instead of the passed-in mm.
Yes, Dave. Peter made the same suggestion in 4/4. will get this fixed in v2.
Thanks Barry
| |