Messages in this thread | | | Date | Thu, 7 Jul 2022 19:30:21 +0000 | From | Sean Christopherson <> | Subject | Re: [PATCH v2 22/28] KVM: VMX: Clear controls obsoleted by EPT at runtime, not setup |
| |
On Thu, Jul 07, 2022, Vitaly Kuznetsov wrote: > Jim Mattson <jmattson@google.com> writes: > > > On Wed, Jun 29, 2022 at 8:07 AM Vitaly Kuznetsov <vkuznets@redhat.com> wrote: > >> > >> From: Sean Christopherson <seanjc@google.com> > >> > >> Clear the CR3 and INVLPG interception controls at runtime based on > >> whether or not EPT is being _used_, as opposed to clearing the bits at > >> setup if EPT is _supported_ in hardware, and then restoring them when EPT > >> is not used. Not mucking with the base config will allow using the base > >> config as the starting point for emulating the VMX capability MSRs. > >> > >> Signed-off-by: Sean Christopherson <seanjc@google.com> > >> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> > > Nit: These controls aren't "obsoleted" by EPT; they're just no longer > > required.
Isn't that the definition of "obsolete"? They're "no longer in use" when KVM enables EPT.
> I'm going to update the subject line to "KVM: VMX: Clear controls > unneded with EPT at runtime, not setup" retaining your authorship in v3
That's fine, though s/unneded/unneeded.
| |