Messages in this thread | | | From | Jerome Brunet <> | Subject | Re: [PATCH v1] watchdog: meson: keep running if already active | Date | Wed, 06 Jul 2022 15:24:27 +0200 |
| |
On Wed 06 Jul 2022 at 05:41, Guenter Roeck <linux@roeck-us.net> wrote:
> On Tue, Jul 05, 2022 at 09:29:35PM +0200, Jerome Brunet wrote: >> >> On Tue 05 Jul 2022 at 16:39, Neil Armstrong <narmstrong@baylibre.com> wrote: >> >> > Hi, >> > >> > On 05/07/2022 16:24, Philippe Boos wrote: >> >> If the watchdog is already running (e.g.: started by bootloader) then >> >> the kernel driver should keep the watchdog active but the amlogic driver >> >> turns it off. >> >> Let the driver fix the clock rate then restart the watchdog if it was >> >> previously active. >> >> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com> >> > >> > Please drop this review tag since it was done off-list >> >> Indeed a review was done off-list. >> >> Reviewed-by says a review has been done. I was not aware this applied to >> public reviews only. I probably missed that, would you mind pointing me >> to that rule please ? >> > > Public or not doesn't really matter. However, you can only apply a > Reviewed-by: tag (or any tag, really) if you explicitly received one. > The exchange seems to suggest that you did not receive that tag.
Philippe did receive that Reviewed-by. I gave it to him. Doing his first public patches, he first requested a review off-list to try to get things right and not bother people too much (so much for that :/)
> Please never add any tags on your own.
He did not.
> > On the other side, if the reviewer did send a Reviewed-by: tag off list, > I would kindly ask the reviewer to not do that in the future to avoid > misunderstandings.
No worries. That being said, I have gone over
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst
It just says that Reviewed-by sent on the list should be collected for the following version. Nothing against adding the tag if the job has been done, on or off list. Same goes for Suggested-by, Tested-by, etc.
If I missed something or it is non-written rule, please let me know.
> If you don't want your Reviewed-by: tag attached to > a patch, don't send one. Not everyone will even realize that you sent > your tag off-list, and no one can be expected to know that you didn't > really mean it when you sent your tag.
I do want Philippe to add it. I would not have given it the first place if it was not the case.
> > Thanks, > Guenter
| |