lkml.org 
[lkml]   [2022]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v1 02/16] dt-bindings: memory: mediatek: Update condition for mt8195 smi node
    From


    On 04/07/2022 14:36, Krzysztof Kozlowski wrote:
    > On 04/07/2022 12:00, Tinghan Shen wrote:
    >> The max clock items for the dts node with compatible
    >> 'mediatek,mt8195-smi-sub-common' should be 3.
    >>
    >> However, the dtbs_check of such node will get following message,
    >> arch/arm64/boot/dts/mediatek/mt8195-evb.dtb: smi@14010000: clock-names: ['apb', 'smi', 'gals0'] is too long
    >> From schema: Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
    >>
    >> Remove the last 'else' checking to fix this error.
    >
    > Missing fixes tag.
    >

    From my understanding, fixes tags are for patches that fix bugs (hw is not
    working etc) and not a warning message from dtbs_check. So my point of view
    would be to not add a fixes tag here.

    Regards,
    Matthias

    >>
    >> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
    >> ---
    >> .../memory-controllers/mediatek,smi-common.yaml | 10 +++++++++-
    >> 1 file changed, 9 insertions(+), 1 deletion(-)
    >>
    >> diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
    >> index a98b359bf909..e5f553e2e12a 100644
    >> --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
    >> +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
    >> @@ -143,7 +143,15 @@ allOf:
    >> - const: gals0
    >> - const: gals1
    >>
    >> - else: # for gen2 HW that don't have gals
    >> + - if: # for gen2 HW that don't have gals
    >> + properties:
    >> + compatible:
    >> + enum:
    >> + - mediatek,mt2712-smi-common
    >> + - mediatek,mt8167-smi-common
    >> + - mediatek,mt8173-smi-common
    >> +
    >
    > Without looking at the code, it's impossible to understand what you are
    > doing here. The commit msg says one, but you are doing something else.
    >
    > Write commit msg explaining what you want to achieve and what you are doing.
    >
    >
    > Best regards,
    > Krzysztof

    \
     
     \ /
      Last update: 2022-07-06 15:49    [W:2.520 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site