lkml.org 
[lkml]   [2022]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 08/16] arm64: dts: mt8195: Add power domains controller
From


On 04/07/2022 14:38, Krzysztof Kozlowski wrote:
> On 04/07/2022 12:00, Tinghan Shen wrote:
>> Add power domains controller node for mt8195.
>>
>> Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
>> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
>> ---
>> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 327 +++++++++++++++++++++++
>> 1 file changed, 327 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>> index 8d59a7da3271..d52e140d9271 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
>> @@ -10,6 +10,7 @@
>> #include <dt-bindings/interrupt-controller/irq.h>
>> #include <dt-bindings/phy/phy.h>
>> #include <dt-bindings/pinctrl/mt8195-pinfunc.h>
>> +#include <dt-bindings/power/mt8195-power.h>
>>
>> / {
>> compatible = "mediatek,mt8195";
>> @@ -338,6 +339,332 @@
>> #interrupt-cells = <2>;
>> };
>>
>> + scpsys: syscon@10006000 {
>> + compatible = "syscon", "simple-mfd";
>
> These compatibles cannot be alone.
>

You mean we would need something like "mediatek,scpsys" as dummy compatible
that's not bound to any driver?

>> + reg = <0 0x10006000 0 0x1000>;
>> + #power-domain-cells = <1>;
>
> If it is simple MFD, then probably it is not a power domain provider.
> Decide.

The SCPSYS IP block of MediaTek SoCs group several functionality, one is the
power domain controller. Others are not yet implemented, but defining the scpsys
as a MFD will give us the possibility to do so in the future.

Regards,
Matthias

>
> Best regards,
> Krzysztof

\
 
 \ /
  Last update: 2022-07-06 15:42    [W:1.727 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site