| Subject | Re: [PATCH v2 07/21] KVM: x86: Use DR7_GD macro instead of open coding check in emulator | From | Maxim Levitsky <> | Date | Wed, 06 Jul 2022 14:58:18 +0300 |
| |
On Tue, 2022-06-14 at 20:47 +0000, Sean Christopherson wrote: > Use DR7_GD in the emulator instead of open coding the check, and drop a > comically wrong comment. > > Signed-off-by: Sean Christopherson <seanjc@google.com> > --- > arch/x86/kvm/emulate.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index 39ea9138224c..bf499716d9d3 100644 > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -4182,8 +4182,7 @@ static int check_dr7_gd(struct x86_emulate_ctxt *ctxt) > > ctxt->ops->get_dr(ctxt, 7, &dr7); > > - /* Check if DR7.Global_Enable is set */ > - return dr7 & (1 << 13); > + return dr7 & DR7_GD; > } > > static int check_dr_read(struct x86_emulate_ctxt *ctxt)
Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
Best regards, Maxim Levitsky
|