lkml.org 
[lkml]   [2022]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ptrace: fix clearing of JOBCTL_TRACED in ptrace_unfreeze_traced()
On Wed, Jul 06, 2022 at 01:04:38PM +0200, Oleg Nesterov wrote:
> On 07/06, Sven Schnelle wrote:
> >
> > --- a/kernel/ptrace.c
> > +++ b/kernel/ptrace.c
> > @@ -222,7 +222,7 @@ static void ptrace_unfreeze_traced(struct task_struct *task)
> > if (lock_task_sighand(task, &flags)) {
> > task->jobctl &= ~JOBCTL_PTRACE_FROZEN;
> > if (__fatal_signal_pending(task)) {
> > - task->jobctl &= ~TASK_TRACED;
> > + task->jobctl &= ~JOBCTL_TRACED;
>
> Heh. I have read this code many times, but I'm afraid I could read it
> 1000 times more and didn't notice the problem ;)

Heh, same here, I've read it today and didn't spot the problem. Brains
are weird.

\
 
 \ /
  Last update: 2022-07-06 13:15    [W:0.117 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site