Messages in this thread | | | Date | Wed, 6 Jul 2022 10:53:33 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH] dmaengine: lgm: Fix an error handling path in intel_ldma_probe() |
| |
On 22-05-22, 19:41, Christophe JAILLET wrote: > ldma_clk_disable() calls both: > clk_disable_unprepare(d->core_clk); > reset_control_assert(d->rst); > > So, should devm_reset_control_get_optional() fail, core_clk should not > be prepare_enable'd before it, otherwise it will never be > disable_unprepare'd. > > Reorder the code to handle the error handling path as expected.
Applied, thanks
-- ~Vinod
| |