lkml.org 
[lkml]   [2022]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dmaengine: lgm: Fix an error handling path in intel_ldma_probe()
On 22-05-22, 19:41, Christophe JAILLET wrote:
> ldma_clk_disable() calls both:
> clk_disable_unprepare(d->core_clk);
> reset_control_assert(d->rst);
>
> So, should devm_reset_control_get_optional() fail, core_clk should not
> be prepare_enable'd before it, otherwise it will never be
> disable_unprepare'd.
>
> Reorder the code to handle the error handling path as expected.

Applied, thanks

--
~Vinod

\
 
 \ /
  Last update: 2022-07-06 07:24    [W:0.083 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site