lkml.org 
[lkml]   [2022]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] ARM: dts: kswitch-d10: enable the USB device port
Date
Hi, Michael,

On 05.07.2022 16:06, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Now that there is driver support for the USB device, enable it.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> index 5a6c5f7c371a..d0d26e136c38 100644
> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> @@ -200,6 +200,11 @@ &switch {
> status = "okay";
> };
>
> +&udc {
> + atmel,vbus-gpio = <&gpio 66 GPIO_ACTIVE_HIGH>;

Can you also add pinctrl to avoid issues described in:

commit 5ba6291086d2ae8006be9e0f19bf2001a85c9dc1
Author: Cristian Birsan <cristian.birsan@microchip.com>
Date: Wed Nov 18 14:00:17 2020 +0200

ARM: dts: at91: sam9x60: add pincontrol for USB Host

The pincontrol node is needed for USB Host since Linux v5.7-rc1. Without
it the driver probes but VBus is not powered because of wrong pincontrol
configuration.

Fixes: 1e5f532c2737 ("ARM: dts: at91: sam9x60: add device tree for soc
and board")
Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Link:
https://lore.kernel.org/r/20201118120019.1257580-2-cristian.birsan@microchip.com

Thank you,
Claudiu Beznea

> + status = "okay";
> +};
> +
> &watchdog {
> status = "okay";
> };
> --
> 2.30.2
>

\
 
 \ /
  Last update: 2022-07-06 10:42    [W:0.300 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site