Messages in this thread | | | From | Dmitry Baryshkov <> | Date | Wed, 6 Jul 2022 11:23:46 +0300 | Subject | Re: [PATCH 1/5] dt-bindings: clock: fix wrong clock documentation for qcom,rpmcc |
| |
On Tue, 5 Jul 2022 at 23:56, Christian Marangi <ansuelsmth@gmail.com> wrote: > > qcom,rpmcc describe 2 different kind of device. > Currently we have definition for rpm-smd based device but we lack > Documentation for simple rpm based device. > > Add the missing clk for ipq806x, apq8060, msm8660 and apq8064 and > provide and additional example. > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > --- > .../devicetree/bindings/clock/qcom,rpmcc.yaml | 77 ++++++++++++++++++- > 1 file changed, 73 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml > index 9d296b89a8d0..028eb0277495 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml [,,,,]
> + > +then: > + properties: > + clocks: > + description: pxo clock > + > + clock-names: > + const: pxo > + > + required: > + - clocks > + - clock-names
I don't think you can not mark these properties as required, older schemas do not have them.
> + > +else: > + if: > + properties: > + compatible: > + contains: > + const: qcom,rpmcc-apq8064 > + then: > + properties: > + clocks: > + items: > + - description: pxo clock > + - description: cxo clock [...]
-- With best wishes Dmitry
| |