Messages in this thread Patch in this message | | | From | Jianglei Nie <> | Subject | [PATCH] usb: cdnsp: Fix potential memory leak in cdnsp_alloc_stream_info() | Date | Wed, 6 Jul 2022 15:59:21 +0800 |
| |
cdnsp_alloc_stream_info() allocates stream context array for stream_info ->stream_ctx_array with cdnsp_alloc_stream_ctx(). When some error occurs, stream_info->stream_ctx_array is not released, which will lead to a memory leak.
We can fix it by releasing the stream_info->stream_ctx_array with cdnsp_free_stream_ctx() on the error path to avoid the potential memory leak.
Signed-off-by: Jianglei Nie <niejianglei2021@163.com> --- drivers/usb/cdns3/cdnsp-mem.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/usb/cdns3/cdnsp-mem.c b/drivers/usb/cdns3/cdnsp-mem.c index 97866bfb2da9..319037848151 100644 --- a/drivers/usb/cdns3/cdnsp-mem.c +++ b/drivers/usb/cdns3/cdnsp-mem.c @@ -631,6 +631,7 @@ int cdnsp_alloc_stream_info(struct cdnsp_device *pdev, stream_info->stream_rings[cur_stream] = NULL; } } + cdnsp_free_stream_ctx(pdev, pep); cleanup_stream_rings: kfree(pep->stream_info.stream_rings); -- 2.25.1
| |