Messages in this thread Patch in this message | | | From | Claudiu Beznea <> | Subject | [PATCH 1/2] irqchip/atmel-aic: remove #ifdef CONFIG_PM | Date | Wed, 6 Jul 2022 10:46:29 +0300 |
| |
Remove #ifdef CONFIG_PM around aic_suspend() function. Coding style recommends (at chapter Conditional Compilation) to avoid using preprocessor conditional in .c files. gc->chip_types->chip.irq_suspend()/gc->chip_types->chip.irq_resume() is called in irq_gc_suspend()/irq_gc_resume() which is NULL in case CONFIG_PM is not defined. With this gc->chip_types->chip.irq_pm_shutdown is populated all the time as it should be as irq_gc_shutdown() is not conditioned by CONFIG_PM.
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com> --- drivers/irqchip/irq-atmel-aic.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/drivers/irqchip/irq-atmel-aic.c b/drivers/irqchip/irq-atmel-aic.c index 4631f6847953..02a9f45a7d2e 100644 --- a/drivers/irqchip/irq-atmel-aic.c +++ b/drivers/irqchip/irq-atmel-aic.c @@ -102,7 +102,6 @@ static int aic_set_type(struct irq_data *d, unsigned type) return 0; } -#ifdef CONFIG_PM static void aic_suspend(struct irq_data *d) { struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d); @@ -132,11 +131,6 @@ static void aic_pm_shutdown(struct irq_data *d) irq_reg_writel(gc, 0xffffffff, AT91_AIC_ICCR); irq_gc_unlock(gc); } -#else -#define aic_suspend NULL -#define aic_resume NULL -#define aic_pm_shutdown NULL -#endif /* CONFIG_PM */ static void __init aic_hw_init(struct irq_domain *domain) { -- 2.34.1
| |