Messages in this thread |  | | Subject | Re: [PATCH] ima/evm: Fix potential memory leak in ima_init_crypto() | From | Mimi Zohar <> | Date | Wed, 06 Jul 2022 23:19:07 -0400 |
| |
Hi Jianglei,
Thank you for the patch.
On Mon, 2022-07-04 at 08:59 +0800, Jianglei Nie wrote: > ima_init_crypto() allocates a memory chunk for "ima_algo_array" with > kcalloc(). When some errors occur, the function jumps to "out_array" > and releases the "ima_algo_array[i].tfm". But "ima_algo_array" is > not released, which will lead to a memory leak.
There's too much low level code details in the above paragraph. The patch description should be written from a higher level perspective. Refer to the original commit 6d94809af6b0 ("ima: Allocate and initialize tfm for each PCR bank") for an example. > > We can release the ima_algo_array with kfree() when some errors occur > to fix the memory leak.
Please re-word the above sentence in the imperative mode. Refer to Documentation/process/submitting-patches.rst for an example.
thanks,
Mimi > > Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
|  |