lkml.org 
[lkml]   [2022]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: ag71xx: switch to napi_build_skb() to reuse skbuff_heads
On Tue,  5 Jul 2022 08:44:34 +0800 Sieng-Piaw Liew wrote:
> --- a/drivers/net/ethernet/atheros/ag71xx.c
> +++ b/drivers/net/ethernet/atheros/ag71xx.c
> @@ -825,7 +825,7 @@ static int ag71xx_tx_packets(struct ag71xx *ag, bool flush)
> if (!skb)
> continue;
>
> - dev_kfree_skb_any(skb);
> + napi_consume_skb(skb, !flush);

!flush is not sufficient here, napi can be called with a budget of 0.

\
 
 \ /
  Last update: 2022-07-07 04:52    [W:0.386 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site