Messages in this thread | | | Date | Thu, 7 Jul 2022 10:22:32 +0800 | Subject | Re: [PATCH v2 3/6] iommu/vt-d: Refactor iommu information of each domain | From | Baolu Lu <> |
| |
On 2022/7/7 09:01, Tian, Kevin wrote: >> From: Lu Baolu <baolu.lu@linux.intel.com> >> Sent: Saturday, July 2, 2022 9:56 AM >> >> -out_unlock: >> + set_bit(num, iommu->domain_ids); >> + info->refcnt = 1; >> + info->did = num; >> + info->iommu = iommu; >> + domain->nid = iommu->node; > > One nit. this line should be removed as it's incorrect to blindly update > domain->nid and we should just leave to domain_update_iommu_cap() > to decide the right node. Otherwise this causes a policy conflict as > here it is the last attached device deciding the node which is different > from domain_update_iommu_cap() which picks the node of the first > attached device.
Agreed and updated. Thank you!
> > Otherwise, > > Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Best regards, baolu
| |