lkml.org 
[lkml]   [2022]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3 1/5] kunit: unify module and builtin suite definitions
    On Sat, Jun 25, 2022 at 1:10 AM David Gow <davidgow@google.com> wrote:
    >
    > From: Jeremy Kerr <jk@codeconstruct.com.au>
    >
    > Currently, KUnit runs built-in tests and tests loaded from modules
    > differently. For built-in tests, the kunit_test_suite{,s}() macro adds a
    > list of suites in the .kunit_test_suites linker section. However, for
    > kernel modules, a module_init() function is used to run the test suites.
    >
    > This causes problems if tests are included in a module which already
    > defines module_init/exit_module functions, as they'll conflict with the
    > kunit-provided ones.
    >
    > This change removes the kunit-defined module inits, and instead parses
    > the kunit tests from their own section in the module. After module init,
    > we call __kunit_test_suites_init() on the contents of that section,
    > which prepares and runs the suite.
    >
    > This essentially unifies the module- and non-module kunit init formats.
    >
    > Tested-by: Maíra Canal <maira.canal@usp.br>
    > Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
    > Signed-off-by: Daniel Latypov <dlatypov@google.com>
    > Signed-off-by: David Gow <davidgow@google.com>

    Reviewed-by: Brendan Higgins <brendanhiggins@google.com>

    \
     
     \ /
      Last update: 2022-07-06 23:07    [W:7.409 / U:0.568 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site