Messages in this thread | | | Date | Wed, 6 Jul 2022 13:35:26 -0500 | From | Nishanth Menon <> | Subject | Re: [PATCH 6/6] arm64: dts: ti: k3-j7200-mcu-wakeup: Add SA2UL node |
| |
On 13:10-20220706, Andrew Davis wrote: > > > + mcu_crypto: crypto@40900000 { > > > + compatible = "ti,j721e-sa2ul"; > > > + reg = <0x00 0x40900000 0x00 0x1200>; > > > + power-domains = <&k3_pds 265 TI_SCI_PD_SHARED>; > > > + #address-cells = <2>; > > > + #size-cells = <2>; > > > + ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>; > > > + dmas = <&mcu_udmap 0xf501>, <&mcu_udmap 0x7502>, > > > + <&mcu_udmap 0x7503>; > > > + dma-names = "tx", "rx1", "rx2"; > > > + dma-coherent; > > > + > > > + rng: rng@40910000 { > > > + compatible = "inside-secure,safexcel-eip76"; > > > + reg = <0x00 0x40910000 0x00 0x7d>; > > > + interrupts = <GIC_SPI 945 IRQ_TYPE_LEVEL_HIGH>; > > > > Please document why disabled. > > > > Sure thing, will add background info to the commit message.
I'd suggest to document in dts as well. See thread [1]
[1] https://lore.kernel.org/linux-arm-kernel/YiizsYnKB0X9bDY2@atomide.com/
-- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
| |