lkml.org 
[lkml]   [2022]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 5/5] iio: pressure: bmp280: Adds more tunable config parameters for BMP380
On Wed, Jul 6, 2022 at 4:39 PM Angel Iglesias <ang.iglesiasg@gmail.com> wrote:
> On mié, 2022-07-06 at 14:42 +0200, Andy Shevchenko wrote:
> > On Wed, Jul 6, 2022 at 12:51 AM Angel Iglesias <ang.iglesiasg@gmail.com>
> > wrote:
> > > On Mon, 2022-07-04 at 22:08 +0200, Andy Shevchenko wrote:
> > > > On Mon, Jul 4, 2022 at 2:41 AM Angel Iglesias <ang.iglesiasg@gmail.com>
> > > > wrote:

...

> > > > Why do you need to copy'n'paste dozens of the very same comment?
> > > > Wouldn't it be enough to explain it somewhere at the top of the file
> > > > or in the respective documentation (if it exists)?
> >
> > No answer?
>
> Apologies, I'll fix the duplicated comments. Would be a good place for the
> comment before the function "bmp280_write_raw" or at the start of the switch
> block?

I believe you may find the best place yourself. My point is to see no
duplication, that's it.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-07-06 19:51    [W:0.057 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site