lkml.org 
[lkml]   [2022]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 002/102] Revert "drm/amdgpu/display: set vblank_disable_immediate for DC"
    Date
    From: Alex Deucher <alexander.deucher@amd.com>

    commit a775e4e4941bf2f326aa36c58f67bd6c96cac717 upstream.

    This reverts commit 92020e81ddbeac351ea4a19bcf01743f32b9c800.

    This causes stuttering and timeouts with DMCUB for some users
    so revert it until we understand why and safely enable it
    to save power.

    Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1887
    Acked-by: Harry Wentland <harry.wentland@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 1 +
    drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ---
    2 files changed, 1 insertion(+), 3 deletions(-)

    --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
    +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
    @@ -333,6 +333,7 @@ int amdgpu_irq_init(struct amdgpu_device
    if (!amdgpu_device_has_dc_support(adev)) {
    if (!adev->enable_virtual_display)
    /* Disable vblank IRQs aggressively for power-saving */
    + /* XXX: can this be enabled for DC? */
    adev_to_drm(adev)->vblank_disable_immediate = true;

    r = drm_vblank_init(adev_to_drm(adev), adev->mode_info.num_crtc);
    --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    @@ -4286,9 +4286,6 @@ static int amdgpu_dm_initialize_drm_devi
    }
    #endif

    - /* Disable vblank IRQs aggressively for power-saving. */
    - adev_to_drm(adev)->vblank_disable_immediate = true;
    -
    /* loops over all connectors on the board */
    for (i = 0; i < link_cnt; i++) {
    struct dc_link *link = NULL;

    \
     
     \ /
      Last update: 2022-07-05 14:32    [W:4.096 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site