lkml.org 
[lkml]   [2022]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 88/98] drm/msm/gem: Fix error return on fence id alloc fail
    Date
    From: Rob Clark <robdclark@chromium.org>

    [ Upstream commit 08de214138cdea438a0dfcb10d355a6650c6017c ]

    This was a typo, we didn't actually want to return zero.

    Fixes: a61acbbe9cf8 ("drm/msm: Track "seqno" fences by idr")
    Signed-off-by: Rob Clark <robdclark@chromium.org>
    Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Patchwork: https://patchwork.freedesktop.org/patch/491145/
    Link: https://lore.kernel.org/r/20220624184528.4036837-1-robdclark@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/msm/msm_gem_submit.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c
    index 7fb7ff043bcd..1f74bab9e231 100644
    --- a/drivers/gpu/drm/msm/msm_gem_submit.c
    +++ b/drivers/gpu/drm/msm/msm_gem_submit.c
    @@ -889,7 +889,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
    submit->fence_id = idr_alloc_cyclic(&queue->fence_idr,
    submit->user_fence, 1, INT_MAX, GFP_KERNEL);
    if (submit->fence_id < 0) {
    - ret = submit->fence_id = 0;
    + ret = submit->fence_id;
    submit->fence_id = 0;
    goto out;
    }
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-07-05 14:31    [W:2.505 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site