Messages in this thread | | | Date | Tue, 5 Jul 2022 14:08:52 +0200 | Subject | Re: [PATCH 02/20] dt-bindings: media: s5p-mfc: Convert s5p-mfc.txt to new DT schema | From | Krzysztof Kozlowski <> |
| |
On 05/07/2022 13:44, Smitha T Murthy wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] >> Sent: Tuesday, May 17, 2022 7:26 PM >> To: Smitha T Murthy <smitha.t@samsung.com>; linux-arm- >> kernel@lists.infradead.org; linux-media@vger.kernel.org; linux- >> kernel@vger.kernel.org; devicetree@vger.kernel.org >> Cc: m.szyprowski@samsung.com; andrzej.hajda@intel.com; >> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; >> ezequiel@vanguardiasur.com.ar; jernej.skrabec@gmail.com; >> benjamin.gaignard@collabora.com; stanimir.varbanov@linaro.org; >> dillon.minfei@gmail.com; david.plowman@raspberrypi.com; >> mark.rutland@arm.com; robh+dt@kernel.org; krzk+dt@kernel.org; >> andi@etezian.org; alim.akhtar@samsung.com; aswani.reddy@samsung.com; >> pankaj.dubey@samsung.com; linux-fsd@tesla.com >> Subject: Re: [PATCH 02/20] dt-bindings: media: s5p-mfc: Convert s5p-mfc.txt >> to new DT schema >> >> On 17/05/2022 14:55, Smitha T Murthy wrote: >>> Adds DT schema for s5p-mfc in yaml format. >>> >> >> Thank you for your patch. There is something to discuss/improve. >> > > Thank you for the review. >
You responded after two months, I don't remember what I reviewed... Two months periods between resends do not really help to usptream.
> >>> + compatible = "samsung,mfc-v12"; >> >> Does not look like you tested the bindings. Please run `make >> dt_binding_check` (see Documentation/devicetree/bindings/writing- >> schema.rst for instructions). >> Be sure to test your bindings before sending them. >> > > I did do make dtbs and dt_binding_check using v2022.3, I will recheck post these changes. > >>> + reg = <0x12880000 0x10000>; >>> + clock-names = "mfc"; >>> + interrupts = <0 137 4>; >> >> Use interrupt defines. >> > > When I use interrupt defines I get errors as "1. Syntax error: This was due to interrupts field has some macro reference and needed to give absolute value.", hence I gave absolute values.
Look at other DT schema files...
Best regards, Krzysztof
| |