lkml.org 
[lkml]   [2022]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 02/58] nvdimm: Fix badblocks clear off-by-one error
    Date
    From: Chris Ye <chris.ye@intel.com>

    commit ef9102004a87cb3f8b26e000a095a261fc0467d3 upstream.

    nvdimm_clear_badblocks_region() validates badblock clearing requests
    against the span of the region, however it compares the inclusive
    badblock request range to the exclusive region range. Fix up the
    off-by-one error.

    Fixes: 23f498448362 ("libnvdimm: rework region badblocks clearing")
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Chris Ye <chris.ye@intel.com>
    Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
    Link: https://lore.kernel.org/r/165404219489.2445897.9792886413715690399.stgit@dwillia2-xfh
    Signed-off-by: Dan Williams <dan.j.williams@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/nvdimm/bus.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/nvdimm/bus.c
    +++ b/drivers/nvdimm/bus.c
    @@ -187,8 +187,8 @@ static int nvdimm_clear_badblocks_region
    ndr_end = nd_region->ndr_start + nd_region->ndr_size - 1;

    /* make sure we are in the region */
    - if (ctx->phys < nd_region->ndr_start
    - || (ctx->phys + ctx->cleared) > ndr_end)
    + if (ctx->phys < nd_region->ndr_start ||
    + (ctx->phys + ctx->cleared - 1) > ndr_end)
    return 0;

    sector = (ctx->phys - nd_region->ndr_start) / 512;

    \
     
     \ /
      Last update: 2022-07-05 14:11    [W:2.513 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site