lkml.org 
[lkml]   [2022]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 23/33] hwmon: (ibmaem) dont call platform_device_del() if platform_device_add() fails
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit d0e51022a025ca5350fafb8e413a6fe5d4baf833 ]

    If platform_device_add() fails, it no need to call platform_device_del(), split
    platform_device_unregister() into platform_device_del/put(), so platform_device_put()
    can be called separately.

    Fixes: 8808a793f052 ("ibmaem: new driver for power/energy/temp meters in IBM System X hardware")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Link: https://lore.kernel.org/r/20220701074153.4021556-1-yangyingliang@huawei.com
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hwmon/ibmaem.c | 12 ++++++++----
    1 file changed, 8 insertions(+), 4 deletions(-)

    --- a/drivers/hwmon/ibmaem.c
    +++ b/drivers/hwmon/ibmaem.c
    @@ -563,7 +563,7 @@ static int aem_init_aem1_inst(struct aem

    res = platform_device_add(data->pdev);
    if (res)
    - goto ipmi_err;
    + goto dev_add_err;

    platform_set_drvdata(data->pdev, data);

    @@ -611,7 +611,9 @@ hwmon_reg_err:
    ipmi_destroy_user(data->ipmi.user);
    ipmi_err:
    platform_set_drvdata(data->pdev, NULL);
    - platform_device_unregister(data->pdev);
    + platform_device_del(data->pdev);
    +dev_add_err:
    + platform_device_put(data->pdev);
    dev_err:
    ida_simple_remove(&aem_ida, data->id);
    id_err:
    @@ -703,7 +705,7 @@ static int aem_init_aem2_inst(struct aem

    res = platform_device_add(data->pdev);
    if (res)
    - goto ipmi_err;
    + goto dev_add_err;

    platform_set_drvdata(data->pdev, data);

    @@ -751,7 +753,9 @@ hwmon_reg_err:
    ipmi_destroy_user(data->ipmi.user);
    ipmi_err:
    platform_set_drvdata(data->pdev, NULL);
    - platform_device_unregister(data->pdev);
    + platform_device_del(data->pdev);
    +dev_add_err:
    + platform_device_put(data->pdev);
    dev_err:
    ida_simple_remove(&aem_ida, data->id);
    id_err:

    \
     
     \ /
      Last update: 2022-07-05 14:07    [W:4.025 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site