Messages in this thread | | | Date | Tue, 5 Jul 2022 14:00:03 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH 09/43] dt-bindings: phy: qcom,msm8996-qmp-pcie: add example node |
| |
On Tue, Jul 05, 2022 at 01:32:30PM +0200, Krzysztof Kozlowski wrote: > On 05/07/2022 12:22, Johan Hovold wrote: > > On Tue, Jul 05, 2022 at 12:10:29PM +0200, Krzysztof Kozlowski wrote: > >> On 05/07/2022 11:42, Johan Hovold wrote: > >>> Add an example node based on a cleaned up version of msm8996.dtsi. > >>> > >>> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > >> > >> Squash it, please. > > > > Why? It's a new addition to the schema. > > Because it is not really new. When you add new bindings or convert > existing ones (without example), it is expected that example is within > that commit. You do here the same - add entirely new file. Old file had > example and the bindings. You now split some pieces, convert it, so new > file is also expected to come with the bindings. > > The same as there is no point to make half-TXT-YAML conversion, there is > no point in half-split of existing bindings. Either this split is > correct and complete, or it's not a finished commit and we do not commit > half-commits.
Fair enough, I'll squash the examples in.
Thanks for the quick review.
Johan
| |