| Date | Tue, 5 Jul 2022 12:12:25 +0200 | Subject | Re: [PATCH 11/43] dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate reset names | From | Krzysztof Kozlowski <> |
| |
On 05/07/2022 11:42, Johan Hovold wrote: > Drop the unnecessary "lane" suffix from the PHY reset names and mark the > old names as deprecated. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > .../phy/qcom,msm8996-qmp-pcie-phy.yaml | 20 +++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml > index 7931b1fd1476..0bea8270b37e 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml > @@ -94,11 +94,15 @@ patternProperties: > - description: PHY (lane) reset > > reset-names: > - items: > - - enum: > - - lane0 > - - lane1 > - - lane2 > + oneOf: > + - items: > + - const: lane > + - items: > + - enum: > + - lane0 > + - lane1 > + - lane2 > + deprecated: true >
How about just dropping reset-names entirely? Marking entire field deprecated and removing from DTS? The same in the previous patch.
Usually one-item xxx-names do not bring any useful information.
Best regards, Krzysztof
|