Messages in this thread | | | From | Wei Fang <> | Subject | RE: [EXT] Re: [PATCH 1/3] dt-bings: net: fsl,fec: update compatible item | Date | Tue, 5 Jul 2022 07:32:31 +0000 |
| |
Hi Krzysztof,
Thanks for your suggestion, I will resubmit the patch.
-----Original Message----- From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Sent: 2022年7月5日 15:27 To: Wei Fang <wei.fang@nxp.com>; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; s.hauer@pengutronix.de Cc: netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; Peng Fan <peng.fan@nxp.com>; Jacky Bai <ping.bai@nxp.com>; sudeep.holla@arm.com; linux-arm-kernel@lists.infradead.org; Aisheng Dong <aisheng.dong@nxp.com> Subject: Re: [EXT] Re: [PATCH 1/3] dt-bings: net: fsl,fec: update compatible item
Caution: EXT Email
On 05/07/2022 04:47, Wei Fang wrote: > Hi Krzysztof, > > Sorry, I'm still a little confused. Do you mean to modify as follows? >> + - items: >> + - enum: >> + - fsl,imx8ulp-fec >> + - const: fsl,imx6ul-fec >> + - const: fsl,imx6q-fec
Yes
> > And as far as I know, the imx8ulp's fec is reused from imx6ul, they both have the same features. However, the fec of imx8ulp(and imx6ul) is a little different from imx6q, therefore, the functions supported by the driver are also somewhat different.
I understand. But if imx8ulp is the same as imx6ul and imx6ul is compatible with imx6q, then I expect imx8ulp to be compatible with imx6ul and with imx6q.
Best regards, Krzysztof
| |